Hoplon + boot-reload appending HTML to body

mdiin · June 16, 2018, 6:23am

Hi,

I have finally started playing with the Hoplon framework for a small project. For that, I decided to pick up Boot again, since I really liked it for cljs-work last time I did that. I’m having trouble getting the browser reload functionality working properly.

The problem is not with picking up the changes; rather it is that the rendered HTML is not replaced. When a hoplon file is reloaded the HTML contents of the body tag are appended to the browser DOM instead of replacing the body tag.

I am not at a computer at the moment, and if someone has an idea but needs more context, I can add a small example later.

Thanks!

jjttjj · June 16, 2018, 5:40pm

I’ve also ran into this and have made a half hearted attempt to get to the bottom of it.

What operating system are you on?

I’ll take another look at it and at least file a bug report if I can’t figure it out

mdiin · June 16, 2018, 7:51pm

Cool! I understand that the hoplon html and body functions are supposed to be singleton, i.e. replace contents on evaluation, so I am guessing it has to be something there? I use Arch Linux.

jjttjj · June 16, 2018, 8:08pm

I know this doesn’t solve your issue, but lately, partly due to this same issue, I’ve been preferring to use hoplon with shadow-cljs.

I threw up a quick skeleton starter project for using the two together here:

I’m still not entirely sure if this is supposed to be necessary or not, but I get rid of the old dom that is being appended to here:

github.com

jjttjj/shadow-hoplon-starter/blob/master/src/shadow_hoplon/core.cljs#L17


(h/html
 (h/head (h/title "shadow+hoplon"))
 (h/body
  (h/div
   (h/h1 "hello, shadow-cljs and hoplon!")))))


;; start is called by init and after code reloading finishes
(defn ^:dev/after-load start []
(js/console.log "start")


(set! (.-innerHTML js/document.documentElement) "")


(attach-page))


(defn ^:export init []
;; init is called ONCE when the page loads
;; this is called in the index.html and must be exported
;; so it is available even in :advanced release builds
(js/console.log "init")
(start))

mdiin · June 17, 2018, 5:34am

I think the clearing of DOM nodes is enough to make reloading work as expected. I will try it when I get the chance and report back. It does feel like a bug though, does it not?

Thanks for looking into this.

mdiin · June 17, 2018, 8:01am

Tried, and adding the clearing of DOM nodes works as expected. Now I just need to figure out how to properly initialize on load.

system · December 16, 2018, 8:01pm

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.